spring starter: add thread details instrumentation / configure logging span exporter #14117
Conversation
github-actions
bot
added
the
test native
zeitlinger
changed the title
|
@laurit please have a look 😄 |
.../spring/autoconfigure/internal/instrumentation/logging/LoggingExporterAutoConfiguration.java
Outdated
Show resolved
Hide resolved
| * This class is internal and is hence not for public use. Its APIs are unstable and can change at | ||
| * any time. | ||
| */ | ||
| @ConditionalOnEnabledInstrumentation(module = "common.thread-details", enabledByDefault = false) |
There was a problem hiding this comment.
agent enables this by default
There was a problem hiding this comment.
@trask please check if thread details should be disabled by default
There was a problem hiding this comment.
sorry, I forgot to raise it in semconv meeting, I've added it to next week's agenda so I won't forget
There was a problem hiding this comment.
@trask do you have an update?
There was a problem hiding this comment.
then it looks like we can leave it as is
...rt/src/main/java/io/opentelemetry/instrumentation/logging/LoggingSpanExporterConfigurer.java
Outdated
Show resolved
Hide resolved
...ort/src/main/java/io/opentelemetry/instrumentation/thread/AddThreadDetailsSpanProcessor.java
Outdated
Show resolved
Hide resolved
zeitlinger
moved this from In Progress
to Awaiting Review
in Declarative Configuration: Java
|
🔧 The result from spotlessApply was committed to the PR branch. |
...entelemetry/instrumentation/internal/resources/ResourceProviderPropertiesCustomizerTest.java
Outdated
Show resolved
Hide resolved
.../spring/autoconfigure/internal/instrumentation/logging/LoggingExporterAutoConfiguration.java
Show resolved
Hide resolved
zeitlinger
force-pushed
the
agent-tracer
branch
from
49c66c3 to
ed45c30
Compare
|
@trask can you check again? |
| public class LoggingExporterAutoConfiguration { | ||
|
|
||
| @Bean | ||
| public AutoConfigurationCustomizerProvider loggingOtelCustomizer() { |
There was a problem hiding this comment.
why only traces and not also metrics and logs? (maybe split the debug behavior out into separate PR? I reviewed the thread stuff and it all looks good to me)
There was a problem hiding this comment.
Good idea: I created #14449 for the thread details
Part of #14087